fix: guard against empty ResizeObserver size arrays#177
Open
tran-simon wants to merge 2 commits intocloudscape-design:mainfrom
Open
fix: guard against empty ResizeObserver size arrays#177tran-simon wants to merge 2 commits intocloudscape-design:mainfrom
tran-simon wants to merge 2 commits intocloudscape-design:mainfrom
Conversation
prevents TypeError when `contentBoxSize` or `borderBoxSize` arrays are empty in certain browser implementation or edge cases.
tran-simon
requested review from
Harsh-Anand-Singh
and removed request for
a team
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
- Coverage 98.82% 98.40% -0.43%
==========================================
Files 40 40
Lines 937 941 +4
Branches 263 255 -8
==========================================
Hits 926 926
- Misses 11 15 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hey, Please review the code cov and failing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
add optional chaining for
contentBoxSizeandborderBoxSizearray.prevents TypeError when
contentBoxSizeorborderBoxSizearrays are empty in certain browser implementations or edge cases.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.